Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent endless waiting for response, without creating resources multiple times (DEV-2860) #586

Merged
merged 1 commit into from Oct 23, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Oct 23, 2023

DEV-2860 prevent endless waiting for response, without creating resources multiple times

Currently, PUT and POST requests in DSP-TOOLS don't have a timeout (ConnectionLive.put() and .post()). This is due to the retry-mechanism try_network_action(): If there is a timeout, there is a risk of duplicated resources in the xmlupload (see DEV-2412, #432).

However, we sometimes have the problem that an xmlupload can hang up itself. This is even worse than creating resources multiple times.

A tradeoff would be to set the timeout to 60 seconds.

To mitigate, a check should be added after the xmlupload is finished: count the number of resources on the server, and warn the user if there are more than in the XML file.

@jnussbaum jnussbaum self-assigned this Oct 23, 2023
@jnussbaum jnussbaum changed the title fix: prevent endless waiting for response, without creating resources multiple times fix: prevent endless waiting for response, without creating resources multiple times (DEV-2860) Oct 23, 2023
Copy link
Contributor

@gNahcab gNahcab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jnussbaum jnussbaum merged commit caa16b7 into main Oct 23, 2023
8 of 9 checks passed
@jnussbaum jnussbaum deleted the wip/DEV-2860-prevent-endless-waiting-for-response branch October 23, 2023 15:00
@daschbot daschbot mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants