Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor graph analysing #589

Merged
merged 8 commits into from Oct 24, 2023
Merged

refactor: refactor graph analysing #589

merged 8 commits into from Oct 24, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Oct 24, 2023
BalduinLandolt
BalduinLandolt approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor remarks

src/dsp_tools/analyse_xml_data/construct_and_analyze_graph.py Outdated Show resolved Hide resolved
src/dsp_tools/analyse_xml_data/models.py Outdated Show resolved Hide resolved
@jnussbaum jnussbaum enabled auto-merge (squash) October 24, 2023 15:15
@jnussbaum jnussbaum merged commit 14a6e83 into main Oct 24, 2023
6 checks passed
@jnussbaum jnussbaum deleted the wip/refactor-graph-analysing branch October 24, 2023 16:01
@daschbot daschbot mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt