Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IRI regex used in multiple places is incorrect (DEV-2888) #606

Merged
merged 2 commits into from Oct 27, 2023
Merged

fix: IRI regex used in multiple places is incorrect (DEV-2888) #606

merged 2 commits into from Oct 27, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Oct 27, 2023

DEV-2888 IRI regex used in multiple places is incorrect

The regex used in different places all over DSP-TOOLS misses that - can be a part of the UUID part of an IRI. In most cases, nothing will happen, but when random creates such an IRI, the automated tests fail.

@jnussbaum jnussbaum self-assigned this Oct 27, 2023
BalduinLandolt
BalduinLandolt approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to store this regex somewhere in a central place, instead of repeating it in multiple places in the code?

@jnussbaum jnussbaum enabled auto-merge (squash) October 27, 2023 13:59
@jnussbaum jnussbaum merged commit 096f47e into main Oct 27, 2023
6 checks passed
@jnussbaum jnussbaum deleted the DEV-2888-iri-regex-used-in-multiple-places-is-incorrect branch October 27, 2023 14:05
@daschbot daschbot mentioned this pull request Oct 27, 2023
Merged
@linear linear bot mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt