New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't create logging handler multiple times (DEV-2891) #609
Conversation
DEV-2881 cleanup stashing algorithm
After implementation in production code (DEV-2), there are some things that should be cleaned up:
|
DEV-2891 logging handler is created multiple times
Probably, this shouldn't happen. it would be better to create in on module level, so that it's created only once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise looking good. Did you notice any difference with only one handler created?
No description provided.