Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log dsp-tools version #612

Merged
merged 6 commits into from Oct 31, 2023
Merged

chore: log dsp-tools version #612

merged 6 commits into from Oct 31, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

BalduinLandolt
BalduinLandolt reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the intent, but I think this could be simplified, see my comment below

src/dsp_tools/cli.py Show resolved Hide resolved
@jnussbaum jnussbaum self-assigned this Oct 31, 2023
@jnussbaum jnussbaum enabled auto-merge (squash) October 31, 2023 09:55
@jnussbaum jnussbaum merged commit ab9ffef into main Oct 31, 2023
8 checks passed
@jnussbaum jnussbaum deleted the wip/log-dsp-tools-version branch October 31, 2023 09:58
@daschbot daschbot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt