Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add specific model for bitstream information (DEV-2893) #613

Merged

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Oct 30, 2023

Another little PR to pave the way for my upcoming PR

@linear
Copy link

linear bot commented Oct 30, 2023

Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but otherwise LGTM

src/dsp_tools/models/xmlresource.py Outdated Show resolved Hide resolved
src/dsp_tools/models/xmlresource.py Outdated Show resolved Hide resolved
src/dsp_tools/models/xmlresource.py Outdated Show resolved Hide resolved
src/dsp_tools/models/xmlresource.py Show resolved Hide resolved
src/dsp_tools/models/xmlresource.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/xmlupload/xmlupload.py Show resolved Hide resolved
BalduinLandolt and others added 3 commits October 31, 2023 10:24
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) October 31, 2023 09:42
@BalduinLandolt BalduinLandolt merged commit 8d0d61d into main Oct 31, 2023
8 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-2893-specific-model-for-bitstreaminfo branch October 31, 2023 09:48
@daschbot daschbot mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants