New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(excel2xml): suppress irrelevant warnings, turn non-fatal errors into warnings (DEV-2917) #625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see here is that with this structure we create XMLs based on excels that are missing mandatory values. Why would this be desirable?
This was not the intention. Rather, I want that the entire program runs through and gives me a list of warnings/errors. Previously, the first error interrupted the program, so the user never knew the entire list of problems. The idea behind this PR is that creating an invalid XML is acceptable, because the user has then a list of problems, so that they can fix them directly in the XML, or they can fix it in the Excel and then run the command again. This PR was born out of a real-world-scenario: I exported dokubib from salsah, converted it to XML, and sent the corrupt XML with the problem list to Rita, who takes care about fixing the problems. |
Could we not set a flag so that we can stop the program in the end if any error occurred? |
https://linear.app/dasch/issue/DEV-2917/