Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xmlupload): fix non-initialized variable (DEV-2922) #629

Merged
merged 6 commits into from Nov 10, 2023
Merged

fix(xmlupload): fix non-initialized variable (DEV-2922) #629

merged 6 commits into from Nov 10, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@linear Linear
Copy link

linear bot commented Nov 10, 2023

DEV-2922 xmlupload: keyboard interrupt isn't handled

All unforeseen errors should lead to a call to _handle_upload_error(). But if a keyboard interrupt happens during uploading the resources, the variable iri_resolver isn't initialized yet, so the program fails ugly, without handling the error.

@jnussbaum jnussbaum self-assigned this Nov 10, 2023
@jnussbaum jnussbaum changed the title fix(xmlupload): handle errors during upload (DEV-2922) fix(xmlupload): fix non-initialized variable (DEV-2922) Nov 10, 2023
@jnussbaum jnussbaum merged commit afb16b1 into main Nov 10, 2023
9 checks passed
@jnussbaum jnussbaum deleted the wip/DEV-2922-xmlupload-keyboard-interrupt-isnt-handled branch November 10, 2023 11:36
@daschbot daschbot mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @Nora-Olivia-Ammann