Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xmlupload): check consistency with ontology on server (DEV-2921) #630

Merged
merged 94 commits into from Nov 29, 2023

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Nov 10, 2023

DEV-2921 check consistency with ontology

The XML is checked in regard with the project ontologies on the server.

The checks include:

  • Do all the resource classes exist?
  • Do all the predicates exist?
  • Do all the permissions exist?
  • Do all the ListNodes exist?

Cardinalities etc, will not be checked.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Nov 14, 2023
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how the PR is shaping up, I added some suggestions, but they are a matter of taste at the end of the day. I'll approve it, but feel free to apply everything you agree with

@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit a563c07 into main Nov 29, 2023
9 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-2921-check-consistency-with-ontology branch November 29, 2023 09:17
@daschbot daschbot mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants