Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: more sourcery refactorings #647

Merged
merged 5 commits into from Nov 16, 2023
Merged

chore: more sourcery refactorings #647

merged 5 commits into from Nov 16, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Nov 16, 2023
BalduinLandolt
BalduinLandolt approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions - feel free to apply them in this PR, later or not at all, as you see fit

src/dsp_tools/commands/project/create/project_create_lists.py Show resolved Hide resolved
src/dsp_tools/commands/project/create/project_validate.py Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/stash/construct_and_analyze_graph.py Show resolved Hide resolved
src/dsp_tools/utils/shared.py Show resolved Hide resolved
src/dsp_tools/utils/shared.py Show resolved Hide resolved
@jnussbaum jnussbaum merged commit 300bfa0 into main Nov 16, 2023
8 of 9 checks passed
@jnussbaum jnussbaum deleted the wip/more-sourcery-refactorings branch November 16, 2023 13:11
@daschbot daschbot mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@Nora-Olivia-Ammann Nora-Olivia-Ammann Awaiting requested review from Nora-Olivia-Ammann

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt