Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace pylint, isort, black with ruff (DEV-2972) #653

Merged
merged 96 commits into from Dec 13, 2023
Merged

chore: replace pylint, isort, black with ruff (DEV-2972) #653

merged 96 commits into from Dec 13, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@linear Linear
Copy link

linear bot commented Nov 23, 2023

DEV-2972 use ruff instead of pylint & black

ruff has a built-in formatter which is almost equivalent to black, but faster.

ruff implements a growing number of pylint rules, plus many others, but is faster than pylint.

@jnussbaum jnussbaum self-assigned this Nov 23, 2023
@jnussbaum
Copy link
Collaborator Author

@Nora-Olivia-Ammann @BalduinLandolt I have now created a concept for how we use ruff: https://www.notion.so/dasch-swiss/Ruff-concept-9fc9658302ad4b35a79be1b83d219d06
Then I reworked this PR, so that it aligns with the concept. What are your thoughts?

BalduinLandolt
BalduinLandolt approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some last remarks, but generally I can get behind this

src/dsp_tools/cli.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2xml/excel2xml_lib.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/start_stack.py Show resolved Hide resolved
Nora-Olivia-Ammann
Nora-Olivia-Ammann approved these changes Dec 12, 2023
View reviewed changes
src/dsp_tools/cli.py Outdated Show resolved Hide resolved
@jnussbaum jnussbaum enabled auto-merge (squash) December 13, 2023 13:38
@jnussbaum jnussbaum merged commit 2594d36 into main Dec 13, 2023
8 of 9 checks passed
@jnussbaum jnussbaum deleted the wip/ruff branch December 13, 2023 13:41
@daschbot daschbot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnussbaum @Nora-Olivia-Ammann @BalduinLandolt