feat(excel2json): new user error (InputError) implementation in properties section (DEV-3037) #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-3024 new Error implementation
The way UserErrors are raised and communicated is inconsistent. With this new protocol the information for the user should be more pertinent and simpler to understand. It is tried out on the excel2json part of the code. |
…tps://github.com/dasch-swiss/dsp-tools into wip/dev-3024-excel2json-new-error-implementation
…tps://github.com/dasch-swiss/dsp-tools into wip/dev-3024-excel2json-new-error-implementation
Nora-Olivia-Ammann
changed the title
BalduinLandolt
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
I think this is a huge improvement. I didn't do the most thorough review, but I added some comments with thoughts on further improvements (and cosmetics). But I definitely feel we're on the right track here, with this error handling. And further refinements can always be done later on.
jnussbaum
approved these changes
Nov 30, 2023
Nora-Olivia-Ammann
deleted the
wip/dev-3024-excel2json-new-error-implementation
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.