Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(process-files): diverse improvements #656

Merged
merged 7 commits into from Dec 6, 2023
Merged

chore(process-files): diverse improvements #656

merged 7 commits into from Dec 6, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Nov 28, 2023
BalduinLandolt
BalduinLandolt approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are things in this one that could be improved, but I would say we can just merge it as is and eventually improve stuff more systematic when we touch this file again

@jnussbaum jnussbaum changed the title feat(process-files): accumulate errors chore(process-files): diverse improvements Dec 6, 2023
@jnussbaum jnussbaum enabled auto-merge (squash) December 6, 2023 08:37
@jnussbaum jnussbaum merged commit 692ad40 into main Dec 6, 2023
9 of 10 checks passed
@jnussbaum jnussbaum deleted the wip/process-files-accumulate-errors branch December 6, 2023 08:41
@daschbot daschbot mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt