Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(excel2json): new error implementation for json validation (DEV-3047) #664

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Dec 1, 2023

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. All my comments are purely cosmetic, feel free to ignore them

src/dsp_tools/commands/excel2json/input_error.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/input_error.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/resources.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/resources.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Show resolved Hide resolved
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit fdbc545 into main Dec 1, 2023
9 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3047-excel2json-error-implementation-resources branch December 1, 2023 17:17
@daschbot daschbot mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants