Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(excel2json): new excel reader (DEV-3049) #665

Merged
merged 10 commits into from Dec 4, 2023

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Dec 4, 2023

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Dec 4, 2023
@Nora-Olivia-Ammann Nora-Olivia-Ammann requested review from jnussbaum and BalduinLandolt and removed request for jnussbaum December 4, 2023 07:58
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor remarks, otherwise looking good

src/dsp_tools/commands/excel2json/resources.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/resources.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/dsp_tools/commands/excel2json/input_error.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/input_error.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/resources.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/resources.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Outdated Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title refactor(excel2json): new excel reader (DEV-3044) refactor(excel2json): new excel reader (DEV-3049) Dec 4, 2023
Copy link

linear bot commented Dec 4, 2023

Nora-Olivia-Ammann and others added 7 commits December 4, 2023 11:56
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit a0d5776 into main Dec 4, 2023
8 of 9 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3044-new-excel-reader-excel2json branch December 4, 2023 14:19
@daschbot daschbot mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants