Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date validation forbids legal values (DEV-3059) #668

Merged
merged 5 commits into from Dec 5, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Dec 5, 2023
Copy link

linear bot commented Dec 5, 2023

@jnussbaum
Copy link
Collaborator Author

@Nora-Olivia-Ammann @BalduinLandolt Docs building fails, because of an outdated link. I opened a separate PR for that.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested one improvement, apart from that it looks good to me

src/dsp_tools/commands/excel2xml/excel2xml_lib.py Outdated Show resolved Hide resolved
@jnussbaum jnussbaum merged commit 13131ff into main Dec 5, 2023
9 checks passed
@jnussbaum jnussbaum deleted the wip/DEV-3059-date-validation-forbids-legal-values branch December 5, 2023 13:29
@daschbot daschbot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants