feat(ingest-upload): create new ingest xmlupload cli command (DEV-3019) #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/dasch-swiss/dsp-tools into wip/dev-3019-create-new-ingest-cli
BalduinLandolt
approved these changes
Dec 20, 2023
test/unittests/commands/ingest_xmlupload/test_apply_ingest_uuid.py
Outdated
Show resolved
Hide resolved
jnussbaum
reviewed
Dec 20, 2023
test/unittests/commands/ingest_xmlupload/test_apply_ingest_id.py
Outdated
Show resolved
Hide resolved
jnussbaum
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Overall, it looks very good. Many of my comments are cosmetical, but some should be addressed before merging. They are commented, but here an overview:
- type annotation of IngestInformation.media_no_id
- should we disallow an xmlupload if there are files that were ingested but not in the XML?
- wrong file given in
_get_unused_path_msg() - We shouldn't add the header "X-Asset-Ingested" to every single POST request that DSP-TOOLS makes, but only if a resource is created via ingest-xmlupload.
- unused test data files (should be removed)
test/unittests/commands/ingest_xmlupload/test_apply_ingest_id.py
Outdated
Show resolved
Hide resolved
test/unittests/commands/ingest_xmlupload/test_apply_ingest_id.py
Outdated
Show resolved
Hide resolved
jnussbaum
reviewed
Dec 22, 2023
jnussbaum
reviewed
Dec 22, 2023
BalduinLandolt
approved these changes
Dec 22, 2023
jnussbaum
approved these changes
Dec 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.