Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): modularise cli.py (DEV-3068) #673

Merged
merged 15 commits into from Dec 7, 2023
Merged

refactor(cli): modularise cli.py (DEV-3068) #673

merged 15 commits into from Dec 7, 2023

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@linear Linear
Copy link

linear bot commented Dec 6, 2023

DEV-3068 clean up cli.py

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Dec 6, 2023
jnussbaum
jnussbaum approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool PR, much better now! I just have some stylistic remarks

src/dsp_tools/cli/cli.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/cli_call_action.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/cli_call_action.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/cli_create_parsers.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/cli_create_parsers.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/cli_create_parsers.py Outdated Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit f0da1ca into main Dec 7, 2023
9 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3068-clean-up-cli.py branch December 7, 2023 10:17
@daschbot daschbot mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nora-Olivia-Ammann @jnussbaum