Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(xmlupload): clean up handle media information (DEV-3086) #677

Merged

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Dec 8, 2023

Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See my comments for some suggestions how to improve.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small remarks, otherwise looking good

src/dsp_tools/commands/xmlupload/resource_multimedia.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/resource_multimedia.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/resource_multimedia.py Outdated Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 93fb71f into main Dec 12, 2023
9 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3086-clean-up-handle-media-information branch December 12, 2023 11:16
@daschbot daschbot mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants