Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(excel2json): find hidden worksheets in excel (DEV-1483) #679

Merged
merged 4 commits into from Dec 12, 2023
Merged

fix(excel2json): find hidden worksheets in excel (DEV-1483) #679

merged 4 commits into from Dec 12, 2023

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@linear Linear
Copy link

linear bot commented Dec 11, 2023

DEV-1483 when reading an Excel file, a hidden sheet might be read instead of the only visible one

@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title fix(excel2json): find hidden worksheets in excel fix(excel2json): find hidden worksheets in excel (DEV-1483) Dec 11, 2023
@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Dec 11, 2023
jnussbaum
jnussbaum approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks, but apart from that, LGTM

src/dsp_tools/commands/excel2json/input_error.py Show resolved Hide resolved
src/dsp_tools/commands/excel2json/input_error.py Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Show resolved Hide resolved
src/dsp_tools/commands/excel2json/properties.py Show resolved Hide resolved
src/dsp_tools/commands/excel2json/utils.py Show resolved Hide resolved
src/dsp_tools/commands/excel2json/properties.py Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit ffbf0c0 into main Dec 12, 2023
9 of 10 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-1483-hidden-excel-sheets branch December 12, 2023 11:03
@daschbot daschbot mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nora-Olivia-Ammann @jnussbaum