fix(excel2json): support uppercase classes sheet in resources.xlsx (DEV-3109) #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnussbaum
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
What's the behavior if one of the resource sheets has wrong capitalization? In case this isn't handled yet, you could consider to first lowercase all resource sheets, similar as I suggested in my comment below for the "classes" sheet.
Apart from that, I added some small suggestions how you could improve it.
But generally LGTM
Nora-Olivia-Ammann
deleted the
wip/dev-3109-support-uppercase-classes
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.