chore: resolve Ruff warnings A003, B023, D103 and PLR0911 #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalduinLandolt
changed the title
Nora-Olivia-Ammann
approved these changes
Dec 14, 2023
jnussbaum
approved these changes
Dec 14, 2023
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Merged
jnussbaum
reviewed
Dec 14, 2023
| @@ -136,38 +137,43 @@ def find_date_in_string(string: str) -> Optional[str]: | |||
| # sanitize input, just in case that the method was called on an empty or N/A cell | |||
| if not check_notna(string): | |||
| return None | |||
| try: | |||
| return _find_date_in_string_throwing(string) | |||
There was a problem hiding this comment.
I don't particularly like this pattern. In fact, no one of the called functions should raise an error, they should just return None if they don't succeed. Then, we don't need a function with this strange name.
(I know that it was me who introduced the ValueErrors, but now I don't like them anymore)
There was a problem hiding this comment.
I am with you on that, but I didn't want to make bigger changes in a simple linting PR. Feel free to adjust that in a separate PR and I will happily approve it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.