Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move retry logic into the connection implementation (DEV-3110) #686

Merged
merged 14 commits into from Dec 15, 2023
Merged

refactor: move retry logic into the connection implementation (DEV-3110) #686

merged 14 commits into from Dec 15, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

No description provided.

@BalduinLandolt BalduinLandolt self-assigned this Dec 14, 2023
@linear Linear
Copy link

linear bot commented Dec 14, 2023

DEV-3110 refactor: invert try_network_action() and Connection class

@BalduinLandolt BalduinLandolt changed the title refactor: move retry logic within the connection implementation (DEV-3110) refactor: move retry logic into the connection implementation (DEV-3110) Dec 14, 2023
@BalduinLandolt BalduinLandolt marked this pull request as ready for review December 14, 2023 16:53
Nora-Olivia-Ammann
Nora-Olivia-Ammann reviewed Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a lot cleaner. But as I said I don't know the original code very well.

jnussbaum
jnussbaum approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement. See my comments about how to tidy this up even more.

src/dsp_tools/commands/project/create/project_create.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/project/create/project_create.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/project/create/project_create.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/project/create/project_create_lists.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/list_client.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Show resolved Hide resolved
BalduinLandolt and others added 2 commits December 15, 2023 11:49
@BalduinLandolt
Merge branch 'main' into feature/dev-3110-refactor-invert-try_network…
f9b58a3 
…_action-and-connection-class
@BalduinLandolt @jnussbaum
apply review suggestions
4903785 
Co-Authored-By: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
@BalduinLandolt BalduinLandolt merged commit f1a7051 into main Dec 15, 2023
8 of 9 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-3110-refactor-invert-try_network_action-and-connection-class branch December 15, 2023 13:28
@daschbot daschbot mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann left review comments

Assignees

@BalduinLandolt BalduinLandolt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BalduinLandolt @jnussbaum @Nora-Olivia-Ammann