New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace bandit action by ruff's bandit ruleset (DEV-3026) #722

Merged

jnussbaum merged 20 commits into main from wip/DEV-3026-bandit

Jan 9, 2024

Collaborator

jnussbaum commented Jan 5, 2024

No description provided.

jnussbaum added 6 commits

January 5, 2024 16:12


          remove bandit.yml

581c099


          resolve S101

d8e8b25


          mute S105, S106

9c42442


          ignore hardcoded passwords globally

34185de


          resolve S602,S607 (subprocess calls)

a86e982


          resolve S301,S104

122f3e5

linear bot commented Jan 5, 2024

DEV-3026 replace disfunctional .github/workflows/bandit.yml with ruff's bandit ruleset

jnussbaum self-assigned this

jnussbaum commented

View reviewed changes

pyproject.toml Show resolved Hide resolved

jnussbaum commented

View reviewed changes

pyproject.toml Show resolved Hide resolved

jnussbaum commented

View reviewed changes

pyproject.toml Show resolved Hide resolved

jnussbaum commented

View reviewed changes

src/dsp_tools/commands/excel2xml/excel2xml_lib.py Show resolved Hide resolved

jnussbaum commented

View reviewed changes

src/dsp_tools/commands/rosetta.py Show resolved Hide resolved

jnussbaum commented

View reviewed changes

src/dsp_tools/commands/xmlupload/upload_config.py Show resolved Hide resolved

jnussbaum added 3 commits

January 5, 2024 19:19


          fix darglint

955d3b9


          mute assert

57c6c46


          fix test_cli.py

76359d5

jnussbaum requested review from BalduinLandolt and Nora-Olivia-Ammann

January 5, 2024 19:06

BalduinLandolt approved these changes

View reviewed changes

Collaborator

BalduinLandolt left a comment

LGTM, I added some cosmetic remarks, but nothing important

src/dsp_tools/commands/excel2xml/excel2xml_cli.py Outdated Show resolved Hide resolved

src/dsp_tools/commands/rosetta.py Outdated Show resolved Hide resolved

src/dsp_tools/commands/start_stack.py Outdated Show resolved Hide resolved

src/dsp_tools/commands/xmlupload/upload_config.py Show resolved Hide resolved

test/e2e/test_cli.py Outdated Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

Nora-Olivia-Ammann approved these changes

View reviewed changes

pyproject.toml Show resolved Hide resolved

jnussbaum added 9 commits

January 8, 2024 09:17


          apply reviewers' feedbacks

1e879c6


          resolve merge conflict

2a8dd43


          Merge branch 'main' into wip/DEV-3026-bandit

6fab069


          more elegant solution for _convert_rows_to_xml()

1c1ea13


          fix excel2xml

4d1b824


          debugging

d6b9472


          fix setup of distribution test

027095c


          add missing line

1b1e71f


          remove print statements

3cd43fd

jnussbaum and others added 2 commits

January 9, 2024 16:51


          take over changes

aad2efa


          Merge branch 'main' into wip/DEV-3026-bandit

227e253

jnussbaum enabled auto-merge (squash)

January 9, 2024 15:52

jnussbaum merged commit 76203cf into main

11 checks passed

jnussbaum deleted the wip/DEV-3026-bandit branch

January 9, 2024 15:55

daschbot mentioned this pull request

chore: release 5.7.0 #697

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment