Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log all HTTP requests, get rid of --dump flag (DEV-3171) #731

Merged
merged 10 commits into from Jan 12, 2024
Merged

chore: log all HTTP requests, get rid of --dump flag (DEV-3171) #731

merged 10 commits into from Jan 12, 2024

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@linear Linear
Copy link

linear bot commented Jan 11, 2024

DEV-3171 instead of dumping HTTP requests, log them with level DEBUG

BalduinLandolt
BalduinLandolt approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thought though, regarding the security alert: Could you actively suppress logging the connection.login() call. It's the only one I can think of, that contains sensitive information (apart from the Token, which you're already stripping out)

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 12, 2024
View reviewed changes
src/dsp_tools/utils/connection_live.py Dismissed Show dismissed Hide dismissed
@jnussbaum jnussbaum merged commit e2b0598 into main Jan 12, 2024
10 of 11 checks passed
@jnussbaum jnussbaum deleted the wip/DEV-3171-log-requests branch January 12, 2024 12:15
@daschbot daschbot mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt