Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve performance with requests.Session object (DEV-3174) #739

Merged
merged 8 commits into from Jan 16, 2024

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Jan 12, 2024

@jnussbaum jnussbaum changed the title chore: improve performance with requests.Session objects (DEV-3174) chore: improve performance with requests.Session object (DEV-3174) Jan 12, 2024
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know session enough at this point to feel confident in my approval. But apart from the comments it looks good to me.

src/dsp_tools/utils/connection_live.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Outdated Show resolved Hide resolved
@jnussbaum jnussbaum merged commit 43caaf9 into main Jan 16, 2024
11 checks passed
@jnussbaum jnussbaum deleted the wip/DEV-3174-requests-session branch January 16, 2024 08:59
@daschbot daschbot mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants