Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent crash when venv isn't activated correctly (DEV-3233) #765

Merged
merged 2 commits into from Jan 25, 2024

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Jan 25, 2024

@jnussbaum jnussbaum self-assigned this Jan 25, 2024
@jnussbaum jnussbaum changed the title fix: prevent crash when venv isn't correctly activated (DEV-3233) fix: prevent crash when venv isn't activated correctly (DEV-3233) Jan 25, 2024
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't know it well enough to really judge. Could we test this?

@jnussbaum
Copy link
Collaborator Author

Looks good, but I don't know it well enough to really judge. Could we test this?

On my machine, it resolved the issue that I had, so I guess it passed the test :-)

@jnussbaum jnussbaum enabled auto-merge (squash) January 25, 2024 13:44
@jnussbaum jnussbaum merged commit 6d339ed into main Jan 25, 2024
11 checks passed
@jnussbaum jnussbaum deleted the wip/prevent-crash-in-version-reading branch January 25, 2024 13:47
@daschbot daschbot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants