Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(excel2json-lists): fix two ruff PLW0603 #778

Merged
merged 5 commits into from Jan 31, 2024
Merged

chore(excel2json-lists): fix two ruff PLW0603 #778

merged 5 commits into from Jan 31, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Jan 31, 2024
jnussbaum
jnussbaum approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for tidying up 👍 I have just one minor remark, feel free to apply it or leave it.

src/dsp_tools/commands/excel2json/list_node_name_model.py Outdated Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 5f53c38 into main Jan 31, 2024
11 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/chore-remove-two-PLW0603 branch January 31, 2024 14:22
@daschbot daschbot mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nora-Olivia-Ammann @jnussbaum