chore: rename value.py file into formatted_text_value.py #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalduinLandolt
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Hitting "Approve" so merging is not blocked.
IMO it is too fine-grained to have a file per value type, so in the long run I would hope to see more than just FormattedTextValue in value.py. And not having to have such long file names where not needed, keeps the imports looking tidier.
So all in all I'm not entirely convinced by this change. But it's up to you - and ultimately also something that could easily be changed back in the future, if need be. So if you feel this makes more sense, then feel free to merge it
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.