Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renaming functions in preparation for TextValue verification #808

Merged
merged 8 commits into from Feb 13, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Feb 12, 2024
@Nora-Olivia-Ammann
Copy link
Collaborator Author

@BalduinLandolt
More work is needed to reorganise some functions but I want to do that separately. Here no actual functional changes should take place.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Naming can probably still improved in some places, but I can't think of anything better for now, so I don't think we should be bothered too much.

@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 9f06f3f into main Feb 13, 2024
10 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/renaming-preparation-for-TextValue-check branch February 13, 2024 08:00
@daschbot daschbot mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants