Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renaming functions of ontology checks in xmlupload #817

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann commented Feb 20, 2024

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Feb 20, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann requested review from jnussbaum and BalduinLandolt and removed request for jnussbaum February 20, 2024 07:32
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the new names are grammatically not correct, and hence, not understandable. See my comments

Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit e6b0e7d into main Feb 20, 2024
10 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/chore-renaming-functions-of-ontology-checks-in-xmlupload branch February 20, 2024 09:25
@daschbot daschbot mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants