feat(xmlupload): check if the encoding in the text-prop is consistent (DEV-3296) #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent' of https://github.com/dasch-swiss/dsp-tools into wip/dev-3296-feat-check-if-text-prop-encoding-is-consistent
jnussbaum
requested changes
Feb 20, 2024
There was a problem hiding this comment.
I like the intention of the PR, and also most of how it is done, but there are 2 main reasons why I'd like to ask you to revise it:
- the present PR contains some changes from another pending PR
- there are many parts of the code that could be simplified / made more pythonic (see my comments)
jnussbaum
reviewed
Feb 22, 2024
jnussbaum
reviewed
Feb 22, 2024
Nora-Olivia-Ammann
deleted the
wip/dev-3296-feat-check-if-text-prop-encoding-is-consistent
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.