refactor(connection): call specific error response codes (DEV-3339) #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnussbaum
changed the title
BalduinLandolt
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
What I am most unhappy with, is that the error handling that lives in the connection object is too specific for such a generic class.
In my opinion what could work is that we do
- a network action without
- the first types of responses are generic as they can happen with any input, for these responses we have the loop automatically
- the second types of error handling are specific depending on when the function is used (xmlupload, create, etc.)
- There we work out the problem
- communicate that
- if it is an error that we want to retry, we enter a function that executes the loop (for simplicity's sake no matter what type of response it gets, it will retry the set amount of times.
- if we don't want to retry we continue
Do you think something like that is feasible?
Nora-Olivia-Ammann
changed the title
Nora-Olivia-Ammann
changed the title
…hub.com/dasch-swiss/dsp-tools into wip/dev-3339-connection-live-error-codehnadling
|
@jnussbaum I was not able to request a review from you, probably because you opened the PR, but I would be glad for your input. |
@nora: LGTM |
Nora-Olivia-Ammann
deleted the
wip/no-retry-on-DuplicateValueException
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.