fix(xmlupload): don't crash if the project has more than 50 errors (DEV-3364) #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nora-Olivia-Ammann
changed the title
Nora-Olivia-Ammann
changed the title
Nora-Olivia-Ammann
changed the title
jnussbaum
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
LGTM. Regarding the PR title: Perhaps it's just me, but I always try to choose a title that reads well in a changelog. So I imagine I scroll through another project's changelog. Then I don't want to see "program crashes if this happens". Rather, I'd like to read "don't crash if this happens".
In this sense, how do you feel about "fix(xmlupload): don't crash if the project has more than 50 errors (DEV-3364)" ?
Nora-Olivia-Ammann
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.