Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): fix crash when no project is on the server (DEV-3405) #875

Merged
merged 4 commits into from Mar 12, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Mar 12, 2024
Copy link

linear bot commented Mar 12, 2024

@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title fix(create): fix crash when no project is on the server fix(create): fix crash when no project is on the server (DEV-3405) Mar 12, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann requested review from jnussbaum and BalduinLandolt and removed request for jnussbaum March 12, 2024 08:26
@Nora-Olivia-Ammann
Copy link
Collaborator Author

Nora-Olivia-Ammann commented Mar 12, 2024

I kept if fairly simple, because in my opinion this is a pretty significant bug, that should be fixed fast. So I did not implement a better error handling regarding the 404 exceptions.
I tried it out with an empty db through the api make commands. Everything worked fine and it looked normal.

@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 9607799 into main Mar 12, 2024
10 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3405-fix-error-when-no-project branch March 12, 2024 08:54
@daschbot daschbot mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants