Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resume-xmlupload): add option to skip the first resource (DEV-3412) #878

Merged
merged 9 commits into from Mar 13, 2024
Merged

feat(resume-xmlupload): add option to skip the first resource (DEV-3412) #878

merged 9 commits into from Mar 13, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Mar 12, 2024
@linear Linear
Copy link

linear bot commented Mar 12, 2024

DEV-3412 don't retry on TimeoutError when API doesn't response

@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title feat(resume-xmlupload): add option to skip the first resource feat(resume-xmlupload): add option to skip the first resource (DEV-3412) Mar 12, 2024
jnussbaum
jnussbaum approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/dsp_tools/cli/call_action.py Show resolved Hide resolved
src/dsp_tools/cli/create_parsers.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/create_parsers.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/create_parsers.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/xmlupload.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/connection_live.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/xmlupload.py Outdated Show resolved Hide resolved
test/unittests/utils/test_connection_live.py Outdated Show resolved Hide resolved
test/unittests/utils/test_connection_live.py Show resolved Hide resolved
BalduinLandolt
BalduinLandolt approved these changes Mar 12, 2024
View reviewed changes
src/dsp_tools/commands/xmlupload/models/upload_state.py Outdated Show resolved Hide resolved
src/dsp_tools/cli/create_parsers.py Outdated Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit a53785f into main Mar 13, 2024
10 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3412-dont-retry-when-api-doesn't-responde branch March 13, 2024 07:55
@daschbot daschbot mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nora-Olivia-Ammann @BalduinLandolt @jnussbaum