feat: save warnings and errors in second file with loguru (DEV-3406) #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve-errors-in-second-file-with-loguru
…ve-errors-in-second-file-with-loguru
…ve-errors-in-second-file-with-loguru
…ttps://github.com/dasch-swiss/dsp-tools into wip/dev-3406-save-errors-in-second-file-with-loguru
jnussbaum
reviewed
Mar 18, 2024
jnussbaum
reviewed
Mar 18, 2024
BalduinLandolt
approved these changes
Mar 18, 2024
jnussbaum
requested changes
Mar 18, 2024
There was a problem hiding this comment.
I'm happy that we switch to loguru, thanks for digging into the subject 👍
Regarding the concrete implementation, I have 2 main concerns:
- I think we shouldn't remove all these
exc_info=True. We need those stack traces. https://loguru.readthedocs.io/en/stable/resources/migration.html#replacing-exc-info-argument describes how the stack trace info can be logged in loguru. - I think we should now remove all the print statements which are just a duplication of the log statement, e.g.
jnussbaum
approved these changes
Mar 19, 2024
Nora-Olivia-Ammann
deleted the
wip/dev-3406-save-errors-in-second-file-with-loguru
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.