fix: excel2properties no longer crashes if optional columns are missing (DEV-3468)

[Nora-Olivia-Ammann]

No description provided.

[linear]

DEV-3468 fix excel2property crashes when an optional column is missing

[jnussbaum]

LGTM. Would it be worth the effort to add a test/test file to prevent regression?

[jnussbaum]

Concerning the PR title: "no longer crashes if optional columns are missing" is a sentence without subject, which is a bit fishy. If I read a changelog, I want to read a list of actions that were taken, e.g. "prevent crash if optional columns are missing"

[Nora-Olivia-Ammann]

LGTM. Would it be worth the effort to add a test/test file to prevent regression?

What would you like to have tested?

[jnussbaum]

LGTM. Would it be worth the effort to add a test/test file to prevent regression?

What would you like to have tested?

Currently, there is no test that prevents us from accidentally fall back into a worse state than we have now (=regression). Ideally, you would write a test that fails on the main branch, but succeeds on this branch here.

[Nora-Olivia-Ammann]

LGTM. Would it be worth the effort to add a test/test file to prevent regression?

What would you like to have tested?

Currently, there is no test that prevents us from accidentally fall back into a worse state than we have now (=regression). Ideally, you would write a test that fails on the main branch, but succeeds on this branch here.

Right I can do that.

[Nora-Olivia-Ammann]

LGTM. Would it be worth the effort to add a test/test file to prevent regression?

What would you like to have tested?

Currently, there is no test that prevents us from accidentally fall back into a worse state than we have now (=regression). Ideally, you would write a test that fails on the main branch, but succeeds on this branch here.

Right I can do that.

I just checked, we do test that and the test never failed. So further confusion abounds, but I am 99% sure we did not make it worse...

[jnussbaum]

LGTM. Would it be worth the effort to add a test/test file to prevent regression?

What would you like to have tested?

Currently, there is no test that prevents us from accidentally fall back into a worse state than we have now (=regression). Ideally, you would write a test that fails on the main branch, but succeeds on this branch here.

Right I can do that.

I just checked, we do test that and the test never failed. So further confusion abounds, but I am 99% sure we did not make it worse...

Ui, that doesn't sound good. This should be investigated. But apart from that, I rather thought about preventing future regression. It can easily happen in some months that someone changes the code and accidentally introduces a new bug.