Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate extra status code #67

Closed
benjamingeer opened this issue Oct 21, 2016 · 3 comments
Closed

Eliminate extra status code #67

benjamingeer opened this issue Oct 21, 2016 · 3 comments
Assignees
Milestone

Comments

@benjamingeer
Copy link
Contributor

When Sipi returns JSON in response to an HTTP request, it returns two status codes:

  1. The standard HTTP status code.
  2. Another status code inside the JSON.

This is confusing and error-prone, and seems redundant. There are cases where Sipi returns HTTP status 200 (OK), but the JSON contains a status code indicating an error: see dasch-swiss/dsp-api#266 .

Can we get rid of the error code inside the JSON, and just use HTTP status codes?

@lrosenth
Copy link
Collaborator

I need some more information to locate the problem: Under what circumstances results this problem. Is it from a Lua script or SIPI intrinsics? Please indicate the URL that produces the problem!

@tobiasschweizer
Copy link
Contributor

I am working on it :-)

@tobiasschweizer
Copy link
Contributor

#66 reports the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants