Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChildSumTreeLSTM : fx and fh linear layer are declare but is not used #4

Closed
ttpro1995 opened this issue May 4, 2017 · 2 comments
Closed

Comments

@ttpro1995
Copy link

Line 21, 22

self.fx = nn.Linear(self.in_dim,self.mem_dim)
self.fh = nn.Linear(self.mem_dim,self.mem_dim)

But it is never use

I think you intend to use in line 38, 39.
(perhaps typo ix with fx )

fx = F.torch.unsqueeze(self.ix(inputs),1)
f = F.torch.cat([self.ih(child_hi)+fx for child_hi in child_h], 0)

@dasguptar
Copy link
Owner

Whoa! Good catch @ttpro1995
So it seems I was a complete klutz, and declared fx, fh but used ix, ih instead. Thanks for spotting it! Let me run the model with the fix and as soon as that is done I will merge your PR as well

@dasguptar
Copy link
Owner

@ttpro1995 Closing this issue for now, because I merged the PR. Let me know if you find any other bugs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants