Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement #130

Closed
zamplyy opened this issue Sep 11, 2023 · 2 comments
Closed

Performance improvement #130

zamplyy opened this issue Sep 11, 2023 · 2 comments

Comments

@zamplyy
Copy link

zamplyy commented Sep 11, 2023

I found while trying out the library that we always render the VEdgeOverlay even though i didn't use the slots.
For performance reasons i think we should only render the edge overlays when we use the slot.

I made a PR to fix this #129
@dash14
Copy link
Owner

dash14 commented Sep 14, 2023

Hi @zamplyy,
Thank you so much!!
As you pointed out, it was rendered even when it was not needed.
Merged the PR from you and released v0.9.8!

@dash14 dash14 closed this as completed Sep 14, 2023
@zamplyy
Copy link
Author

zamplyy commented Sep 15, 2023 •
edited
Loading

No problem! Thanks for merging so quickly @dash14 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dash14 @zamplyy