Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadway v1.0.4 Broadway.NoopAcknowledger returns NoopAcknowledger instead of Broadway.NoopAcknowledger #315

Closed
seantanly opened this issue Nov 6, 2022 · 1 comment
Closed

Broadway v1.0.4 Broadway.NoopAcknowledger returns NoopAcknowledger instead of Broadway.NoopAcknowledger #315

seantanly opened this issue Nov 6, 2022 · 1 comment

Comments

@seantanly
Copy link

Looks like Broadway v1.0.4 has an issue with the noop_acknoledger which returns NoopAcknowledger instead of Broadway.NoopAcknowledger for acknowledger in %Broadway.Message{}.

broadway/lib/broadway/noop_acknowledger.ex

Line 16 in 7c93cdb

{NoopAcknowledger, _ack_ref = nil, _data = nil}

@seantanly
Copy link
Author

Thank you for the speedy fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seantanly