Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saxy #84

Open
ckoch-cars opened this issue Apr 9, 2024 · 1 comment
Open

Saxy #84

ckoch-cars opened this issue Apr 9, 2024 · 1 comment

Comments

@ckoch-cars
Copy link

Saxy seems to be a transient dependency for ExAwsSQS

Saxy itself is marked as optional in ExAwsSQS V3.2.1+
https://github.com/ex-aws/ex_aws_sqs/blob/main/CHANGELOG.md

I think broadway_sqs should not require saxy at all. It should at least be marked as optional (or perhaps limited to :dev and/or :test). It doesn't seem that this project has any explicit dependency on saxy AFAICT.

@josevalim
Copy link
Member

I may be misrembering but I was the one who added Saxy support to ex_aws_sqs because performance is much better. If saxy is not listed, it defaults to something xmerl or something else, which ends up being slower. So us defaulting to that is a way for us to guarantee good performance out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants