Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: multi-xpubs for contacts are not differentiated #9

Open
coolaj86 opened this issue Jun 2, 2023 · 0 comments
Open

Bug: multi-xpubs for contacts are not differentiated #9

coolaj86 opened this issue Jun 2, 2023 · 0 comments

Comments

@coolaj86
Copy link
Member

coolaj86 commented Jun 2, 2023

I had a contact. He misplaced his wallet and so I added him again with a different xpub. The problem is that old addresses referenced by HDPath only, not by the index of the multiple XPubs, so now I get this:

Error: check fail: hdpath 'm/44'/5'/0'/1/1' for 'Xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' derived 'Xyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'

Immediate Workaround

Open the ~/.config/dash/pay-wallets.json and give the new version of him a different name.

Codefix Workaround

Continue to iterate over the contact's wallets on error and only fail if no wallet matches

Future Solution

Use ULIDs to identify contacts and associate each hdpath with a ULID and Account Index. The ULID can represent either a wallet phrase + account index, or an xprv, or xpub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant