Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 Support #46

Closed
gav-nomoss opened this issue Apr 20, 2021 · 2 comments · Fixed by #62
Closed

Vue 3 Support #46

gav-nomoss opened this issue Apr 20, 2021 · 2 comments · Fixed by #62
Labels
enhancement New feature or request

Comments

@gav-nomoss
Copy link

TLDR: We're looking to use vue-ld in a Vue 3 application and it doesn't look like there's support for Vue 3 yet. Is there a timeline on support?

In a Vue 3 app we're configuring main.js like this:

import { createApp } from 'vue'
import App from './App.vue'
import { VueLd } from 'vue-ld';

const app = createApp(App)
app.use(VueLd, {
    clientSideId: 'YOUR_CLIENT_SIDE_ID',
    user: {
        key: '...',
        email: '...',
        name: '...',
    },
    options: {
        // Standard LaunchDarkly JavaScript SDK options
    },
});
app.mount('#app')

When we run the application we're finding that the page doesn't load and we're getting the following error in the console:

Uncaught TypeError: Vue.observable is not a function
    at Object.install (index.es.js:1010)
    at Object.use (runtime-core.esm-bundler.js:3003)
    at main.js:6

I believe this could be because Vue.observable is not supported in Vue 3. Is there a timeline for when vue-ld will support Vue 3? Or, can you point me at a similar tool for Launch Darkly that supports Vue 3?

Thank you!

@kepheusikarius kepheusikarius added the enhancement New feature or request label Apr 20, 2021
@benjamin-t-frost
Copy link
Contributor

@gav-nomoss we will not be ready to work on upgrading to Vue 3 until fall at least; you are welcome to submit a PR if you need a faster timeline.

@gav-nomoss
Copy link
Author

Hey @benjamin-t-frost - thanks for getting back.

We're planning to make use of this library in a Vue 2 project that will eventually be migrated to Vue 3, so it's good to know Vue 3 is on your horizon!

@benjamin-t-frost benjamin-t-frost linked a pull request Dec 22, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants