Fix OSX auto download, see issue #11 #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pierre tested it on his linux machine |
|
That doesn't seem right? Why would coverage of the Javascript reduce if I made a change in the bash script? |
|
We're in the process of merging this repo w/the dashevo one, and we're removing the download entirely from that and making it a separate dependency. This work should be done by early next week at the latest. If this is needed right now, please use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @snogcel,
Fixed this so that I can keep on working on my Mac. I don't know if you have other ideas because I see you guys are creating a .dmg in the release? So no worries if it's declined.