ignore unsupported messages

dashpay · Aug 19, 2016 · 1e600e8 · 1e600e8
1 parent 6b73e73
commit 1e600e8
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/lib/messages/builder.js b/lib/messages/builder.js
@@ -62,6 +62,35 @@ function builder(options) {
       dsq: 'DSQueue',
       ssc: 'SyncStatusCount'
     },
+    unsupportedCommandsMap: [
+      'sendheaders',
+      'ix',
+      'txlvote',
+      'spork',
+      'getsporks',
+      'mnw',
+      'mnget',
+      'mn scan error',
+      'mnvs',
+      'mvote',
+      'mprop',
+      'fbs',
+      'fbvote',
+      'mn quorum',
+      'mnb',
+      'mnp',
+      'dsa',
+      'dsi',
+      'dsf',
+      'dss',
+      'dsc',
+      'dssu',
+      'dstx',
+      'dseg',
+      'govsync',
+      'govobj',
+      'govobjvote'
+    ],
     commands: {}
   };
 

diff --git a/lib/messages/index.js b/lib/messages/index.js
@@ -97,9 +97,9 @@ Messages.prototype._discardUntilNextMessage = function(dataBuffer) {
 };
 
 Messages.prototype._buildFromBuffer = function(command, payload) {
-  if (command === 'sendheaders') return; // BIP 130, ignore 'sendheaders' command
   if (!this.builder.commands[command]) {
-    throw new Error('Unsupported message command: ' + command);
+    if (this.builder.unsupportedCommandsMap.indexOf(command) > -1) return; // ignore unsupported message commands
+    throw new Error('Unrecognized message command: ' + command); // throw error if unrecognized message command
   }
   return this.builder.commands[command].fromBuffer(payload);
 };

diff --git a/test/messages/index.js b/test/messages/index.js
@@ -170,7 +170,7 @@ describe('Messages', function() {
         var bufs = buildMessage(invalidCommand);
         messages.parseBuffer(bufs);
       };
-      fails.should.throw('Unsupported message command: malicious');
+      fails.should.throw('Unrecognized message command: malicious');
     });
 
     it('ignores malformed messages', function() {