Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dapi): failure if bloom filter is not set #1572

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix(dapi): failure if bloom filter is not set #1572

merged 2 commits into from
Nov 20, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 10, 2023 •
edited

Issue being fixed or feature implemented

If bloom filter is not set in SubscribeToTransactionsWithProofsRequest, the corresponding endpoint faild

What was done?

  • Return InvalidArgument error if bloom filter is not set

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.25.x milestone Nov 10, 2023
@shumkov shumkov marked this pull request as ready for review November 10, 2023 11:52
@shumkov shumkov merged commit 7eecfa3 into master Nov 20, 2023
18 of 19 checks passed
@shumkov shumkov deleted the fix/dapi/bloomfilter-is-not-set branch November 20, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antouhou antouhou Awaiting requested review from antouhou antouhou is a code owner

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.x
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shumkov