Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): rs-sdk support for ExtendedEpochInfo::fetch()/fetch_many() #1576

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Nov 13, 2023

Issue being fixed or feature implemented

Added method to fetch one or more ExtendedEpochInfos

What was done?

  • added epoch request/response to rs-dapi-grpc
  • impl Fetch and FetchMany on ExtendedEpochInfo
  • impl FromProof on ExtendedEpochInfo
  • on dapi-grpc, impl From<MessageV0> for Message for all versioned messages

How Has This Been Tested?

Added unit tests

Setup local devnet with yarn dashmate config set --config local_3 platform.drive.abci.epochTime 300

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the base branch from v1.0-dev to feat/register November 13, 2023 16:51
@lklimek lklimek changed the base branch from feat/register to rs-sdk/merge-register-1.0 November 14, 2023 13:53
Base automatically changed from rs-sdk/merge-register-1.0 to feat/register November 15, 2023 14:23
@lklimek lklimek changed the base branch from feat/register to v1.0-dev November 15, 2023 14:51
@lklimek lklimek marked this pull request as ready for review November 15, 2023 14:52
@lklimek lklimek merged commit 77eed1d into v1.0-dev Nov 16, 2023
33 checks passed
@lklimek lklimek deleted the rs-sdk/epoch_info branch November 16, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants