Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): publicIp.v4 function is undefined #1587

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

pshenmic
Copy link
Collaborator

Issue being fixed or feature implemented

Fix few bugs found by @strophy and Node.JS v20 leftover

What was done?

  • Fixed imports for table dependency
  • Fixed imports for public-ip dependency
  • Corrected dashmate status core block height color when remoteBlockHeight is null

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic added this to the v0.25.x milestone Nov 21, 2023
@pshenmic pshenmic changed the title Hotfix/dashmate bugs fix(dashmate): bugfixes Nov 21, 2023
@pshenmic pshenmic changed the title fix(dashmate): bugfixes fix(dashmate): tiny bugfixes Nov 21, 2023
@shumkov shumkov changed the title fix(dashmate): tiny bugfixes fix(dashmate): publicIp.v4 function is undefined Nov 21, 2023
@pshenmic pshenmic merged commit 1f4ffea into master Nov 21, 2023
22 checks passed
@pshenmic pshenmic deleted the hotfix/dashmate-bugs branch November 21, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants